zhangbutao commented on code in PR #10666:
URL: https://github.com/apache/iceberg/pull/10666#discussion_r1671604534
##########
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -335,7 +373,13 @@ private CloseableIterable<T> open(FileScanTask
currentTask, Schema readSchema) {
case HIVE:
return openTask(currentTask, readSchema);
case GENERIC:
- DeleteFilter deletes = new GenericDeleteFilter(io, currentTask,
tableSchema, readSchema);
+ DeleteFilter deletes =
Review Comment:
In which case can the cache be used to speed up task execution?
I mean that one tez task gets the deletes only once, so when is the next
time the cache deletes would be used?
But I noticed that the ObjectCache can be useful when container is reused,
see https://issues.apache.org/jira/browse/HIVE-5151, so if tez task for iceberg
is reused `iceberg.mr.reuse.containers`, can the cache work well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
