pvary commented on code in PR #10666:
URL: https://github.com/apache/iceberg/pull/10666#discussion_r1672886432
##########
mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -335,7 +373,13 @@ private CloseableIterable<T> open(FileScanTask
currentTask, Schema readSchema) {
case HIVE:
return openTask(currentTask, readSchema);
case GENERIC:
- DeleteFilter deletes = new GenericDeleteFilter(io, currentTask,
tableSchema, readSchema);
+ DeleteFilter deletes =
Review Comment:
The community plans to upgrade the Java version, which is reasonable at this
time. Java 8 support is long gone.
If Hive plans to support Iceberg 1.7 or later, then Hive needs to upgrade
the Java version.
If there is a Hive version which doesn't block the Java upgrade, then we
could suggest to upgrade Hive instead of dropping the support. I'm not sure
that the community will support the notion, but I would prefer to keep a few
connectors inside the Iceberg repo to ensure long-term compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
