nastra commented on code in PR #10673:
URL: https://github.com/apache/iceberg/pull/10673#discussion_r1672596840
##########
mr/src/main/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedSupport.java:
##########
@@ -34,11 +34,11 @@ public enum Support {
this.lowerCaseName = name().toLowerCase(Locale.ROOT);
}
- public static final Map<String, Support> nameToSupportMap =
Maps.newHashMap();
+ public static final Map<String, Support> NAME_TO_SUPPORT_MAP =
Maps.newHashMap();
Review Comment:
just adding some additional context that Iceberg only provides API/ABI
stability for certain modules (`iceberg-mr` module isn't included) which is
enforced by `revapi`, but great if we can avoid breaking the API/ABI for
modules where we don't enforce it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
