attilakreiner commented on code in PR #10673:
URL: https://github.com/apache/iceberg/pull/10673#discussion_r1673884503
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -284,6 +284,10 @@
<property name="format" value="^[a-z][a-zA-Z0-9]+$"/>
<message key="name.invalidPattern" value="Member name ''{0}'' must
match pattern ''{1}''."/>
</module>
+ <module name="ConstantName">
+ <property name="format" value="^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$"/>
Review Comment:
Thanks, I see. I experimented a bit with the possessive quantifiers in the
regexes as well as removing some custom messages that seem redundant.
I created a draft PR with these changes: #10681. Even though it seems like
just a few lines of changes, it has an impact for the whole codebase and I
don't want to hold up this one. (I'd prefer to keep the scope of this PR tight,
really just renaming the constants to uppercase and enforcing that rule.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
