attilakreiner commented on code in PR #10681:
URL: https://github.com/apache/iceberg/pull/10681#discussion_r1673979787
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -480,23 +475,20 @@
<module name="LocalFinalVariableName"/> <!-- Java Style Guide: Local
variable names -->
<module name="LocalVariableName"> <!-- Java Style Guide: Local
variable names -->
<property name="tokens" value="VARIABLE_DEF"/>
- <property name="format" value="^[a-z][a-zA-Z0-9]+$"/>
+ <property name="format" value="^[a-z][a-zA-Z0-9]++$"/>
<property name="allowOneCharVarInForLoop" value="true"/>
- <message key="name.invalidPattern" value="Local variable name
''{0}'' must match pattern ''{1}''."/>
</module>
<module name="MethodLength"/> <!-- Java Coding Guide: Methods and
functions: focused, crisp, concise -->
<module name="MethodTypeParameterName"> <!-- Java Style Guide: Type
variable names -->
- <property name="format"
value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
- <message key="name.invalidPattern" value="Method type name ''{0}''
must match pattern ''{1}''."/>
+ <property name="format"
value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*+[T]$)"/>
Review Comment:
You're right, thx for point it out. I reverted this one change. I double
checked the other changes for similar issues and they LGTM. Pls chk and LMK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
