RussellSpitzer commented on code in PR #10681:
URL: https://github.com/apache/iceberg/pull/10681#discussion_r1678370083
##########
.baseline/checkstyle/checkstyle.xml:
##########
@@ -281,16 +280,13 @@
</module>
<module name="InnerAssignment"/> <!-- Java Coding Guidelines: Inner
assignments: Not used -->
<module name="MemberName"> <!-- Java Style Guide: Non-constant field
names -->
- <property name="format" value="^[a-z][a-zA-Z0-9]+$"/>
- <message key="name.invalidPattern" value="Member name ''{0}'' must
match pattern ''{1}''."/>
+ <property name="format" value="^[a-z][a-zA-Z0-9]++$"/>
Review Comment:
Well checkstyle currently takes less than 1 second on my machine :) so I'm
not super worried about the perf. In reading your article it does seem like
this is a situation where a good regex engine wouldn't backtrack anyway because
$ is incompatible with the previous matching class. Is Java a good regex
engine? I don't know.
Anyway, I have no problem with merging this since it is semantically the
same for our purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
