guilload commented on pull request #1243: URL: https://github.com/apache/iceberg/pull/1243#issuecomment-663773025
Yeah, if we don't mind having as many test classes as catalog implementations then I can do that. Also, is the running time of the Iceberg test suite something we care about? `HiveRunner` is rather slow (I believe each test sets up a new local HMS from scratch) and `TestHiveIcebergInputFormat` takes about 4 minutes to run on my machine (compile time included). Running that test with more catalog implementations is only going to increase that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
