rdsr commented on a change in pull request #1243:
URL: https://github.com/apache/iceberg/pull/1243#discussion_r460586335
##########
File path: mr/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java
##########
@@ -95,15 +93,12 @@ public ConfigBuilder schema(Schema schema) {
}
public ConfigBuilder readFrom(TableIdentifier identifier) {
- return readFrom(identifier.toString());
- }
-
- public ConfigBuilder readFrom(File path) {
- return readFrom(path.toString());
+ conf.set(TABLE_IDENTIFIER, identifier.toString());
+ return this;
}
- public ConfigBuilder readFrom(String path) {
- conf.set(TABLE_PATH, path);
+ public ConfigBuilder readFrom(File location) {
Review comment:
Shouldn't this be `InputFile`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
