amogh-jahagirdar commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692046113
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -3647,6 +3826,151 @@ components:
type: integer
description: "List of equality field IDs"
+ DeleteFile:
+ oneOf:
+ - $ref: '#/components/schemas/PositionDeleteFile'
+ - $ref: '#/components/schemas/EqualityDeleteFile'
+
+ PreplanTableRequest:
+ type: object
+ oneOf:
+ - required:
+ - snapshot-id
+ - required:
+ - start-snapshot-id
Review Comment:
This is certainly closer but I think we'll need to make sure this is how we
specify mutually exclusive fields.
https://stackoverflow.com/questions/21134029/how-to-define-mutually-exclusive-query-parameters-in-swagger-openapi/49199240#49199240
I know the link above is for URL query params but maybe the same principle
applies?
Also at minimum I think we need to document that servers must throw a 400 if
neither a snapshot ID nor a start and end snapshot ID pair are specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
