rahil-c commented on code in PR #9695:
URL: https://github.com/apache/iceberg/pull/9695#discussion_r1692457387
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -537,6 +537,113 @@ paths:
5XX:
$ref: '#/components/responses/ServerErrorResponse'
+ /v1/{prefix}/namespaces/{namespace}/tables/{table}/preplan:
Review Comment:
> I think there's a fair point that if we only have one capability, clients
can call either endpoint first. I'd definitely recommend calling plan first,
but that's up to the client and, more importantly, because we don't need to
require a certain behavior we should not require a certain behavior. Specs
should be flexible and leave room for implementations to be smart.
I agree with this that we should not require a client to have to call
`preplan` or `plan` first. However `plan` to me is the core capability and that
the client will likely be calling this first, especially when the client does
not need to leverage a `preplan` to distribute this work up if for a small
table scan.
If we say this is the recommendation but not requirement where are we
mentioning this? Is this within the `plan` endpoint description? @rdblue
@amogh-jahagirdar @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
