kbendick commented on a change in pull request #1227:
URL: https://github.com/apache/iceberg/pull/1227#discussion_r463306415
##########
File path: dev/source-release.sh
##########
@@ -66,7 +66,11 @@ tarball=$tag.tar.gz
# be conservative and use the release hash, even though git produces the same
# archive (identical hashes) using the scm tag
-git archive $release_hash --prefix $tag/ -o $tarball .baseline api arrow
bundled-guava common core data dev flink gradle gradlew hive mr orc parquet pig
spark spark2 spark-runtime spark3 spark3-runtime LICENSE NOTICE README.md
build.gradle baseline.gradle deploy.gradle tasks.gradle jmh.gradle
gradle.properties settings.gradle versions.lock versions.props version.txt
+adds=" .baseline" # prefixed with a blank space for each file name including
the first one
+excludes="build|examples|jitpack.yml|python|site"
Review comment:
Should we consider printing a warning to the console of what are the
`$excludes` in case a file is introduced that needs to be added? A comment
might also serve here about adding to `$excludes` if need be.
##########
File path: dev/source-release.sh
##########
@@ -66,7 +66,11 @@ tarball=$tag.tar.gz
# be conservative and use the release hash, even though git produces the same
# archive (identical hashes) using the scm tag
-git archive $release_hash --prefix $tag/ -o $tarball .baseline api arrow
bundled-guava common core data dev flink gradle gradlew hive mr orc parquet pig
spark spark2 spark-runtime spark3 spark3-runtime LICENSE NOTICE README.md
build.gradle baseline.gradle deploy.gradle tasks.gradle jmh.gradle
gradle.properties settings.gradle versions.lock versions.props version.txt
+adds=" .baseline" # prefixed with a blank space for each file name including
the first one
+excludes="build|examples|jitpack.yml|python|site"
+archives=$(ls | grep -vE ${excludes})${adds}
+echo git archive list: ${archives}
Review comment:
If I add `archives=$(echo $archives | tr '\n' ' ')`, then my `$archives`
output is space delimited as I believe is the expected behavior for input to
`git archive`.
```bash
$ echo ${archives}
LICENSE
NOTICE
README.md
api
arrow
baseline.gradle
bundled-guava
common
core
data
deploy.gradle
dev
flink
gradle
gradle.properties
gradlew
hive
jmh.gradle
mr
orc
parquet
pig
settings.gradle
spark
spark-runtime
spark2
spark3
spark3-runtime
tasks.gradle
versions.props .baseline
$ archives=$(echo $archives | tr '\n' ' ')
$ echo $archives
LICENSE NOTICE README.md api arrow baseline.gradle bundled-guava common core
data deploy.gradle dev flink gradle gradle.properties gradlew hive jmh.gradle
mr orc parquet pig settings.gradle spark spark-runtime spark2 spark3
spark3-runtime tasks.gradle versions.props .baseline
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
