kbendick commented on a change in pull request #1227:
URL: https://github.com/apache/iceberg/pull/1227#discussion_r483925144
##########
File path: dev/source-release.sh
##########
@@ -66,7 +66,12 @@ tarball=$tag.tar.gz
# be conservative and use the release hash, even though git produces the same
# archive (identical hashes) using the scm tag
-git archive $release_hash --prefix $tag/ -o $tarball .baseline api arrow
bundled-guava common core data dev flink gradle gradlew hive mr orc parquet pig
spark spark2 spark-runtime spark3 spark3-runtime LICENSE NOTICE README.md
build.gradle baseline.gradle deploy.gradle tasks.gradle jmh.gradle
gradle.properties settings.gradle versions.lock versions.props version.txt
+adds=" .baseline" # prefixed with a blank space for each file name including
the first one
+excludes="build|examples|jitpack.yml|python|site" # excluded as they are not
of use for releasing jars
+echo WARNING! The following files/directories are to be excluded from git
archive: ${excludes}
Review comment:
Can you please use quotes with `echo`? I'm not sure which shell you're
using, but I suspect that this isn't going to be portable.
i.e. `echo "NOTE: The following files/directories are to be excluded from
git archive: ${excludes}"`.
Additionally, and this is more of a nit, but I would use `NOTE` over
`WARNING`. To me, this is more of an info (or even debug) level log of sorts,
and the use of `WARNING` might be confusing for someone simply glancing over
it. Again, more of a nit really, but the quotes for `echo` are a best practice
(if not typically required in some shells for correctness reasons.).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
