kbendick commented on a change in pull request #1289: URL: https://github.com/apache/iceberg/pull/1289#discussion_r465529235
########## File path: .github/autolabeler.yml ########## @@ -0,0 +1,83 @@ + +# The following paragraph was taken from the Apache Spark project. +# see: https://github.com/apache/spark/blob/master/.github/autolabeler.yml +# Bot page: https://github.com/apps/probot-autolabeler +# The matching patterns follow the .gitignore spec. +# See: https://git-scm.com/docs/gitignore#_pattern_format +# Also, note that the plugin uses 'ignore' package. See also +# https://github.com/kaelzhang/node-ignore + +INFRA: + - ".baseline/" + - ".github/" + - "/dev/" + - ".asf.yaml" + - ".gitattributes" + - ".gitignore" + - "baseline.gradle" + - "deploy.gradle" + - "jitpack.yml" + - "site/mkdocs.yml" + - "travis.yml" +BUILD: + - "/dev/" + - "/project/" + - "/assembly/" + - "*pom.xml" + - "/bin/docker-image-tool.sh" + - "/bin/find-spark-home*" + - "gradle/" + - "**.gradle" +BASH: + - "dev/check-license" + - "**.sh" +DOCS: + - "site/" + - "!/site/mkdocs.yml" + - "**CHANGELOG.md" + - "**LICENSE" + - "**NOTICE" + - "**README.md" +EXAMPLES: + - "examples/" +COMMON: + - "common/" +API: + - "api/" + - "python/iceberg/api/" + - "python/tests/api/" +CORE: + - "**/core/" Review comment: Ok. That sounds good to me. I was thinking in the case where `python` might get expanded out more in the future, but I am now leaning more towards your simpler is better approach. I'll remove all of the matches for subdirectories. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
