kbendick edited a comment on pull request #1289: URL: https://github.com/apache/iceberg/pull/1289#issuecomment-669081045
> @kbendick How could we verify the effect of this patch ? Fork my own iceberg repo and upload a spark test PR in my own repo, will it create a label for the PR ? It will be better if we have a verification. > Thanks for the nice work. To verify this patch, I first need to submit a few small changes to the configuration file (based on my misinterpretation of the format). Then, somebody with write access on this repository needs to enable the autolabeler bot by navigating to here https://github.com/apps/probot-autolabeler and then configuring the bot to have the permissions that it requests for this repository only. The permission set is relatively benign. I can link a screen shot if need be. This should be acceptable as the spark project is using it. Then, the labels do not need to be precreated. They will be generated when PRs are submitted. If one wants to pick the colors for the labels or add descriptions to them, this can be configured either by creating the label initially or by editing the labels on this page: https://github.com/apache/iceberg/issues/labels After I submit one more patch to the labeler yaml file, once it's merged it will start working as expected. I have demonstrated this in my own fork both here for an MR label [kbendick#7](https://github.com/kbendick/iceberg/pull/7) and here for a FLINK label [kbendick#8](https://github.com/kbendick/iceberg/pull/8). I much prefer them with color, but this can be dealt with after the initial set up is merged (and confirmed by others if they so wish). I will submit a final patch to make it into a working state and then allow time for any additional comments to the original configuration. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
