RussellSpitzer commented on a change in pull request #1264:
URL: https://github.com/apache/iceberg/pull/1264#discussion_r467091047
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseAction.java
##########
@@ -41,4 +51,47 @@ protected String metadataTableName(MetadataTableType type) {
return tableName + "." + type;
}
}
+
+ protected Dataset<Row> buildValidDataFileDF(SparkSession spark) {
+ String allDataFilesMetadataTable =
metadataTableName(MetadataTableType.ALL_DATA_FILES);
+ return
spark.read().format("iceberg").load(allDataFilesMetadataTable).select("file_path");
+ }
+
+ protected Dataset<Row> buildManifestFileDF(SparkSession spark) {
+ String allManifestsMetadataTable =
metadataTableName(MetadataTableType.ALL_MANIFESTS);
+ return
spark.read().format("iceberg").load(allManifestsMetadataTable).selectExpr("path
as file_path");
+ }
+
+ protected Dataset<Row> buildManifestListDF(SparkSession spark, Table table) {
+ List<String> manifestLists = Lists.newArrayList();
Review comment:
Sure I can move these over to a new TableUtil class in the core module
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
