rdblue commented on a change in pull request #1145:
URL: https://github.com/apache/iceberg/pull/1145#discussion_r467150635
##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -357,7 +358,7 @@ public ByteBuffer keyMetadata() {
@Override
public List<Long> splitOffsets() {
- return splitOffsets;
+ return splitOffsets != null ? Lists.newArrayList(splitOffsets) : null;
Review comment:
Should this return an `ImmutableList` so that it cannot be modified?
That's what was happening before, although I think it matter less if this is
creating a new list each time it is returned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
