openinx commented on a change in pull request #1145:
URL: https://github.com/apache/iceberg/pull/1145#discussion_r467306978
##########
File path: core/src/main/java/org/apache/iceberg/BaseFile.java
##########
@@ -357,7 +358,7 @@ public ByteBuffer keyMetadata() {
@Override
public List<Long> splitOffsets() {
- return splitOffsets;
+ return splitOffsets != null ? Lists.newArrayList(splitOffsets) : null;
Review comment:
I thought that we use unmodified collection before because we don't
wanna to change the contents inside splitOffsets. Now we've accomplished the
same purpose. Returning it as modifiable or unmodifiable collection, both of
them sounds good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
