rdblue commented on a change in pull request #1216:
URL: https://github.com/apache/iceberg/pull/1216#discussion_r467338601
##########
File path: python/iceberg/core/base_metastore_tables.py
##########
@@ -16,28 +16,51 @@
# under the License.
from iceberg.api import Tables
-from iceberg.exceptions import NoSuchTableException
+from iceberg.exceptions import AlreadyExistsException, CommitFailedException,
NoSuchTableException
from .base_table import BaseTable
+from .table_metadata import TableMetadata
class BaseMetastoreTables(Tables):
+ DOT = '.'
def __init__(self, conf):
self.conf = conf
def new_table_ops(self, conf, database, table):
raise RuntimeError("Abstract Implementation")
- def load(self, database, table):
+ def load(self, table_identifier):
Review comment:
Minor: if we add types, the docs are better. For example, changing this
to `table_identifier: str` made it so that documentation for `str.rsplit` is
found, at least in PyCharm. We should probably start adding types where it
makes sense, like in the base class `Tables`.
Not something we need to do in this commit, but it really helps reviewing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
