rdblue commented on a change in pull request #1216:
URL: https://github.com/apache/iceberg/pull/1216#discussion_r467338885
##########
File path: python/iceberg/core/filesystem/filesystem_tables.py
##########
@@ -36,15 +35,15 @@ def load(self, location):
return BaseTable(ops, location)
- def create(self, schema, table_identifier=None, spec=None,
properties=None, location=None):
+ def create(self, schema, table_identifier=None, spec=None,
properties=None):
Review comment:
I agree with using table_identifier here. Should we also rename it in
`load` since the location is the table identifier for FS tables?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
