kbendick commented on issue #1328: URL: https://github.com/apache/iceberg/issues/1328#issuecomment-673465778
Oh and while we're on the subject, here's my open PR on the ByteBuffers class of warnings from Error Prone. https://github.com/apache/iceberg/pull/1334 There's one area, writing ByteBuffers to Orc files, that I can't tell if I can be sure if the buffer was allocated on or off heap. The working example I have is a spark application writing to orc-files that has off-heap enabled memory. I would love your input on this small PR if you have time (of if you could ping people more versed in Orc than myself. I'm more comfortable with Parquet). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
