RussellSpitzer commented on issue #1328:
URL: https://github.com/apache/iceberg/issues/1328#issuecomment-675100339
This is an incomplete upgrade but enough to compile the new code and expose
the new warnings.
**Version Bumps**
baseline 0.55 -> 3.36.2
git-version 0.9 -> 0.12.3
**Checkstyle Changes Require for Compile**
- LineLength no longer is a Treewalker so it needs to be moved
- MissingJavaDocMethod is now it's own module, allowMissingThrows is now
validate throws
- MinLineCount was owned by MissingJavaDocMethod but we only set this to a
huge number
**FindBug Suppression Required for Compile**
- StrictUnusedVariables must be disabled because we have several hundred
cases of method parameters not being used in their bodies
**New Checkstyle Violations**
- RightCurly - We use Same but this triggers on private constructors with
same line braces
**New Baseline/Findbug Warnings**
- Final Class - Class not declared final but all constructors are private
- Javadoc Missing Summary - No Summary mostly in our case this is where we
have methods with only a `@return`
- RawTypes - Using a parameterized class without a parameterized type
- ReferenceEquality - We have a few instances of == instead of Equals
- LambdaMethodReference - Using s -> s.foo instead of s::foo
- LoggerEnclosingClass - using getLogger for super in child
- UncessaryAnonymousClass - Extend Function instead of using a lambda
- CollectionUndefinedEquality - Using equality or contains on Collection
without it's own equals or badly behaving equality like (UTF8 strings)
- JDKObsolete : Collection of many things
- - Using Date (we use Date internally in some places we don't need to be
using it)
- - Using linked list ( Warning argues that it is not performed compared to
ArrayList and we should us that unless we need nulls or want to benchmark)
- - SortedMap is deprecated use NavigableMap instead
- Public constructor for Abstract Class
- CollectionStreamForeach : Collection.stream.foreach should be
Collection.foreach
- MissingOverrides
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
