rdblue commented on a change in pull request #1338:
URL: https://github.com/apache/iceberg/pull/1338#discussion_r471808271
##########
File path: parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
##########
@@ -383,10 +383,7 @@ public DeleteWriteBuilder equalityFieldIds(int...
fieldIds) {
meta("delete-type", "position");
- if (rowSchema != null) {
- Preconditions.checkState(createWriterFunc != null,
- "Cannot create delete file with deletes rows unless
createWriterFunc is set");
-
+ if (rowSchema != null && createWriterFunc != null) {
Review comment:
Checking for `createWriterFunc` here is needed because `forTable` sets
the row schema. So rows can be included in position deletes when the writer
func is added and when there is a row schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
