rdblue commented on a change in pull request #1338:
URL: https://github.com/apache/iceberg/pull/1338#discussion_r472357915
##########
File path: core/src/main/java/org/apache/iceberg/avro/Avro.java
##########
@@ -300,10 +300,7 @@ public DeleteWriteBuilder equalityFieldIds(int...
fieldIds) {
meta("delete-type", "position");
- if (rowSchema != null) {
- Preconditions.checkState(createWriterFunc != null,
- "Cannot create delete file with deletes rows unless
createWriterFunc is set");
-
+ if (rowSchema != null && createWriterFunc != null) {
Review comment:
Using `forTable` sets the row schema automatically, so we can't
determine that the user intended to write rows that way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
