rdblue commented on a change in pull request #1216:
URL: https://github.com/apache/iceberg/pull/1216#discussion_r475786217



##########
File path: python/iceberg/hive/hive_table_operations.py
##########
@@ -85,20 +89,20 @@ def commit(self, base, metadata):
 
             tbl.sd = storage_descriptor(metadata)
             metadata_location = 
tbl.parameters.get(BaseMetastoreTableOperations.METADATA_LOCATION_PROP, None)
-            base_metadata_location = base.metadataFileLocation() if base is 
not None else None
+            base_metadata_location = base.location if base else None

Review comment:
       That seems confusing to me. How do you get the table's base location in 
Python?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to