rymurr commented on a change in pull request #1216:
URL: https://github.com/apache/iceberg/pull/1216#discussion_r475798239
##########
File path: python/iceberg/hive/hive_table_operations.py
##########
@@ -85,20 +89,20 @@ def commit(self, base, metadata):
tbl.sd = storage_descriptor(metadata)
metadata_location =
tbl.parameters.get(BaseMetastoreTableOperations.METADATA_LOCATION_PROP, None)
- base_metadata_location = base.metadataFileLocation() if base is
not None else None
+ base_metadata_location = base.location if base else None
Review comment:
ahh, i see now. It appears that the Java and Python impls are a bit out
of sync. Python doesn't use `file` at all, which is where java takes its
location from. Will look at figuring out what happened there and update the PR
this eve or tomorrow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
