pvary commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r478405334



##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -465,9 +495,14 @@ protected void finalize() throws Throwable {
     super.finalize();
     if (!closed) {
       close(); // releasing resources is more important than printing the 
warning
-      String trace = Joiner.on("\n\t").join(
+      String trace = Joiner.on("\\n\t").join(

Review comment:
       Collapsing the multiline log to a single line - was not brave enough to 
remove the \n-s altogether.
   This should create logs like:
   ```
   Unclosed input stream created by:\n {Stacktrace.line1\n  Stractrace.line2\n  
Stractrace.line3}
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to