rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r478760172
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -143,9 +144,11 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
// TODO add lock heart beating for cases where default lock timeout is
too low.
Table tbl;
if (base != null) {
+ LOG.info("Committing existing table [{}]", fullName);
Review comment:
I think these changes are too verbose for INFO, although I do think it
would be good to have a log message for the commit.
Could you add an INFO log in `BaseMetastoreTableOperations#commit` instead
of these? Something like this:
```java
LOG.info("Successfully committed to table {} in {} ms: {}", table.name(),
end - start, newMetadataLocation);
```
That way, logging is not too verbose, consistent across implementations, and
adds useful info: the time it took to commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
