aokolnychyi commented on a change in pull request #1397:
URL: https://github.com/apache/iceberg/pull/1397#discussion_r478709284
##########
File path: core/src/main/java/org/apache/iceberg/ManifestFiles.java
##########
@@ -23,15 +23,30 @@
import java.util.Map;
import org.apache.iceberg.ManifestReader.FileType;
import org.apache.iceberg.exceptions.RuntimeIOException;
+import org.apache.iceberg.io.CloseableIterable;
import org.apache.iceberg.io.FileIO;
import org.apache.iceberg.io.InputFile;
import org.apache.iceberg.io.OutputFile;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
public class ManifestFiles {
private ManifestFiles() {
}
+ /**
+ * Returns a {@link CloseableIterable} of file paths in the {@link
ManifestFile}.
+ *
+ * @param manifest a ManifestFile
+ * @param io a FileIO
+ * @return a manifest reader
+ */
+ public static CloseableIterable<String> readPaths(ManifestFile manifest,
FileIO io) {
Review comment:
Do we want to document or reflect in the name that we return paths for
liveEntries only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
