aokolnychyi commented on a change in pull request #1397:
URL: https://github.com/apache/iceberg/pull/1397#discussion_r478712647
##########
File path: spark/src/main/java/org/apache/iceberg/actions/BaseAction.java
##########
@@ -94,9 +102,30 @@ protected String metadataTableName(String tableName,
MetadataTableType type) {
return buildValidDataFileDF(spark, table().toString());
}
+ private static class ReadManifest implements
FlatMapFunction<ManifestFileBean, String> {
Review comment:
In other actions, we have private static methods at the end of the
classes like below:
```
private static FlatMapFunction<Iterator<String>, String> listDirsRecursively(
Broadcast<SerializableConfiguration> conf,
long olderThanTimestamp) {
return (FlatMapFunction<Iterator<String>, String>) dirs -> {
// logic
};
}
```
I am OK with this approach too but may make sense to align it with other
places.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
