rdblue commented on pull request #1389: URL: https://github.com/apache/iceberg/pull/1389#issuecomment-683351935
Thanks, @jzhuge! I think the current implementation is fairly clean and I like how it injects the clock through `TableOperations`. That is a good place to inject table customization and this alters a lot fewer classes now. I'm not sure that this solution is needed, though. I don't know of any use cases that would use a clock to inject custom timestamp logic, so adding this through `TableOperations` adds unnecessary complexity to an interface that is extended by external libraries. I am also not sure that this is the best option for tests because it isn't obvious what relationship the clock has to the other operations because it is passed in at table creation time through the superclass. The logic isn't very obvious, compared to the approach of calling `waitUntilAfter(snapshot.timestampMillis())`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
