HeartSaVioR commented on pull request #1389: URL: https://github.com/apache/iceberg/pull/1389#issuecomment-690836103
In general, manual clock like this is widely used for testing and I see it very helpful, but according to the changeset it looks to affect just a couple of tests which looks to be very minor, compared to the impact of the change performed to the source side. Places I see using manual clocks are testing timeout functionality, which would add multi-seconds or minutes which aren't what we really want to actually sleep to wait. Here the test just busy-waits for 1 ms per each, which is trivial to just wait. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
