rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r481375297
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -329,7 +350,9 @@ private boolean alterHiveDataBase(Namespace namespace,
Database database) {
try {
Database database = clients.run(client ->
client.getDatabase(namespace.level(0)));
- return convertToMetadata(database);
+ Map<String, String> metadata = convertToMetadata(database);
+ LOG.debug("Loaded metadata for namespace {}", namespace);
Review comment:
Sorry, but I didn't catch this before. This is logging a property map
that could contain sensitive items. Could you log just the keys instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
