rdblue commented on a change in pull request #1394:
URL: https://github.com/apache/iceberg/pull/1394#discussion_r481377034
##########
File path: hive/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -138,9 +141,11 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
dropTableData(ops.io(), lastMetadata);
}
+ LOG.info("Table is dropped [{}]", identifier);
Review comment:
For concerns like this, I prefer to have a `quote` method that handles
special characters. That way you get a readable error message when everything
is normal, but the space problem is highlighted when it needs to be. So
`ident.quote()` would return `db.table` normally and `db."table "` if there is
a trailing space.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
