RussellSpitzer commented on a change in pull request #1427:
URL: https://github.com/apache/iceberg/pull/1427#discussion_r483837957
##########
File path: core/src/main/java/org/apache/iceberg/DeleteFileIndex.java
##########
@@ -361,7 +361,7 @@ DeleteFileIndex build() {
deleteEntries.add(entry.copy());
}
} catch (IOException e) {
- throw new RuntimeIOException("Failed to close", e);
Review comment:
Previous Usage was Broken
##########
File path: core/src/main/java/org/apache/iceberg/ManifestFilterManager.java
##########
@@ -300,7 +300,7 @@ private ManifestFile filterManifest(StrictMetricsEvaluator
metricsEvaluator, Man
return filterManifestWithDeletedFiles(metricsEvaluator, manifest,
reader);
} catch (IOException e) {
- throw new RuntimeIOException("Failed to close manifest: " + manifest, e);
Review comment:
Previous Usage was Broken
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
