RussellSpitzer commented on a change in pull request #1427:
URL: https://github.com/apache/iceberg/pull/1427#discussion_r483840443
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkExceptionUtil.java
##########
@@ -39,7 +40,9 @@ private SparkExceptionUtil() {
* @param args format specifiers
* @return unchecked exception.
*/
- public static RuntimeException toUncheckedException(Throwable cause, String
message, Object... args) {
+ @FormatMethod
+ public static RuntimeException toUncheckedException(final Throwable cause,
final String message,
Review comment:
FormatMethod needs all variables to be effectively final. We do a lot of
casting here which maybe screws up error-prone's analysis because we don't
actually change anything here but ErrorProne still complains. Declaring
everything final fixes it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
