kbendick commented on pull request #1227: URL: https://github.com/apache/iceberg/pull/1227#issuecomment-687572568
Thank you so much for returning to this @waterlx! I have concerns about not using quotes when calling `echo`. It's not technically required in all shells, but it's fairly standard and it gives me some slight concerns for portability (especially if people are running in containers and using stricter shells). Other than that, it looks greatl though I have a small nit / suggestion for making the script slightly more readable (but I'll leave that to your call). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
