kbendick commented on pull request #1227: URL: https://github.com/apache/iceberg/pull/1227#issuecomment-691811328
> I just tried running this locally, but it failed with this error: `fatal: pathspec 'bdp-iceberg' did not match any files` > > It looks like the list operation can introduce files or directories that aren't tracked by git and will cause the command to fail. > > The idea behind using `git archive` with a list was to ensure that the local copy doesn't leak into the archive so you can have extra files and folders that are automatically ignored. If we committed this, then a release manager would need to fix their local copy before running the script. > > Can we fix this by getting the listing from `git` instead? Yeah we can definitely fix this by getting a list from `git ls-tree`. We've already worked on some changes, but I think I might have a fix for the last problem (some weird issue with using the assigned `archives` variable as a shell variable). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
