kbendick commented on a change in pull request #1420: URL: https://github.com/apache/iceberg/pull/1420#discussion_r483934150
########## File path: api/src/main/java/org/apache/iceberg/ManifestProcessor.java ########## @@ -0,0 +1,33 @@ +/* + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.iceberg; + +import java.io.Serializable; +import java.util.function.BiFunction; +import org.apache.iceberg.io.CloseableIterable; +import org.apache.iceberg.io.FileIO; + +public abstract class ManifestProcessor implements Serializable { + public abstract <T extends ContentFile<T>> Iterable<CloseableIterable<ManifestEntry<T>>> readManifests(final Iterable<ManifestFile> fromIterable, + BiFunction<ManifestFile, FileIO, CloseableIterable<ManifestEntry<T>>> reader); + + /** + * A Helper interface for making lambdas transform into the correct type for the ManfiestProcessor + * @param <T> The ManifestEntry Type being read from Manifest files + */ + public interface Func<T extends ContentFile<T>> extends BiFunction<ManifestFile, FileIO, + CloseableIterable<ManifestEntry<T>>>, Serializable {} Review comment: I know this is a WIP, so I'm partially commenting to follow along. But I'm not a huge fan of this interface being named `Func`. Its usage also feels somewhat clunky to me to be honest, but I'm more of a scala developer than a java developer by day so that could possibly just be my own bias showing. Overall this is shaping up to be a great addition though. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
