kbendick commented on a change in pull request #1420:
URL: https://github.com/apache/iceberg/pull/1420#discussion_r487581440
##########
File path: api/src/main/java/org/apache/iceberg/ManifestEntry.java
##########
@@ -25,7 +20,7 @@
import static org.apache.iceberg.types.Types.NestedField.optional;
import static org.apache.iceberg.types.Types.NestedField.required;
-interface ManifestEntry<F extends ContentFile<F>> {
+public interface ManifestEntry<F extends ContentFile<F>> {
Review comment:
Can you expand on why making `ManifestEntry` public makes the API harder
to use? Is it just because we then have to account for the fact that this is a
public API?
I personally am more fond of this proof of concept as opposed to the other
one, so I'd love to get insight into your comment here.
If it's just because we would then have to treat this API public, is it
possible something could be done to mark it as private to iceberg, equivalent
to scala's `private[iceberg]`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
