RussellSpitzer commented on a change in pull request #1446:
URL: https://github.com/apache/iceberg/pull/1446#discussion_r488130057
##########
File path: core/src/main/java/org/apache/iceberg/DeleteFileIndex.java
##########
@@ -76,7 +76,7 @@
ImmutableMap.Builder<Integer, Types.StructType> builder =
ImmutableMap.builder();
specsById.forEach((specId, spec) -> builder.put(specId,
spec.partitionType()));
this.partitionTypeById = builder.build();
- this.wrapperById = Maps.newHashMap();
+ this.wrapperById = Maps.newConcurrentMap();
Review comment:
My only preference is that it lets you set the "ifAbsent" method as
default, so you don't actually have to call computeIfAbsent when getting. But I
have no preference, just the usage in ManifestGroup doesn't use invalidation or
expiration so I was wondering if there was a reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
