rdblue commented on a change in pull request #1446:
URL: https://github.com/apache/iceberg/pull/1446#discussion_r488821589



##########
File path: core/src/main/java/org/apache/iceberg/DeleteFileIndex.java
##########
@@ -76,7 +76,7 @@
     ImmutableMap.Builder<Integer, Types.StructType> builder = 
ImmutableMap.builder();
     specsById.forEach((specId, spec) -> builder.put(specId, 
spec.partitionType()));
     this.partitionTypeById = builder.build();
-    this.wrapperById = Maps.newHashMap();
+    this.wrapperById = Maps.newConcurrentMap();

Review comment:
       Thanks for the great context, @ben-manes!
   
   I still expect IO to dominate the cost of planning, but we should certainly 
keep this behavior in mind in the future. I'd be for changing this (and 
possibly other places) over to a cache, but let's keep this PR focused since it 
fixes the current flaky test bug.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to