marton-bod commented on a change in pull request #1455:
URL: https://github.com/apache/iceberg/pull/1455#discussion_r490997376
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergDateObjectInspector.java
##########
@@ -42,17 +42,17 @@ private IcebergDateObjectInspector() {
@Override
public Date getPrimitiveJavaObject(Object o) {
- return o == null ? null : Date.valueOf((LocalDate) o);
+ return o == null ? null : Date.valueOf(o.toString());
Review comment:
Good point! I will fix the conversion logic to avoid using toString. As
for timezones, the expected LocalDate/LocalDateTime objects in these inspectors
contain no timezone information or any offsets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
