rdblue commented on a change in pull request #1455:
URL: https://github.com/apache/iceberg/pull/1455#discussion_r488071685
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergFilterFactory.java
##########
@@ -127,7 +127,7 @@ private static Object leafToLiteral(PredicateLeaf leaf) {
case FLOAT:
return leaf.getLiteral();
case DATE:
- return daysFromTimestamp((Timestamp) leaf.getLiteral());
+ return daysFromDate((Date) leaf.getLiteral());
Review comment:
I think we should check the type returned by `getLiteral` and handle
that here. Then we won't need separate code for different versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
