rdblue commented on a change in pull request #1480:
URL: https://github.com/apache/iceberg/pull/1480#discussion_r492220911
##########
File path:
spark/src/test/java/org/apache/iceberg/spark/data/parquet/vectorized/TestParquetDictionaryEncodedVectorizedReads.java
##########
@@ -38,7 +39,8 @@
public class TestParquetDictionaryEncodedVectorizedReads extends
TestParquetVectorizedReads {
@Override
- Iterable<GenericData.Record> generateData(Schema schema, int numRecords,
long seed, float nullPercentage) {
+ Iterable<GenericData.Record> generateData(Schema schema, int numRecords,
long seed, float nullPercentage,
+ Function<GenericData.Record,
GenericData.Record> transform) {
Review comment:
It's strange that this adds the transform and then ignores it. Is there
a better way to structure this so that it doesn't require doing this? Maybe
just don't call this method in a subclass?
##########
File path: spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java
##########
@@ -99,7 +99,7 @@ public static void assertEqualsBatch(Types.StructType struct,
Iterator<Record> e
if (checkArrowValidityVector) {
ColumnVector columnVector = batch.column(i);
ValueVector arrowVector = ((IcebergArrowColumnVector)
columnVector).vectorAccessor().getVector();
- Assert.assertEquals("Nullability doesn't match", expectedValue ==
null, arrowVector.isNull(rowId));
+ Assert.assertFalse("Nullability doesn't match", expectedValue ==
null ^ arrowVector.isNull(rowId));
Review comment:
Why change this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
