samarthjain commented on a change in pull request #1480:
URL: https://github.com/apache/iceberg/pull/1480#discussion_r492504864
##########
File path: spark/src/test/java/org/apache/iceberg/spark/data/TestHelpers.java
##########
@@ -99,7 +99,7 @@ public static void assertEqualsBatch(Types.StructType struct,
Iterator<Record> e
if (checkArrowValidityVector) {
ColumnVector columnVector = batch.column(i);
ValueVector arrowVector = ((IcebergArrowColumnVector)
columnVector).vectorAccessor().getVector();
- Assert.assertEquals("Nullability doesn't match", expectedValue ==
null, arrowVector.isNull(rowId));
+ Assert.assertFalse("Nullability doesn't match", expectedValue ==
null ^ arrowVector.isNull(rowId));
Review comment:
While stepping through the tests I realized that the case for
`expectedValue != null` wasn't being tested. So I tweaked the check. slightly
to cover both the cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
