kbendick opened a new pull request #1493: URL: https://github.com/apache/iceberg/pull/1493
Several classes have a private named field `defaultDelete`, which is a `Consumer<String>` and is used as a functional interface for removing files etc. We use a functional interface so that users may pass in their own implementation of the functional interface. It is a common pattern in the code base. I tried out the method suggested as a fix, by defining the function as a method `void defaultDelete(String file)` and it got really messy. I suggest we suppress these warnings and move on with it so as to clean up the clutter in the build phase. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
