RussellSpitzer commented on pull request #1493: URL: https://github.com/apache/iceberg/pull/1493#issuecomment-699578815
To be clear I think suppressing is the right move here On Sat, Sep 26, 2020, 8:32 PM Kyle Bendickson <[email protected]> wrote: > Does it fix the warning to use a lambda and cast to Consumer instead? > This could be something like: > > Consumer<String> defaultDelete = (Consumer<String>) file -> io.delete(file); > > I will look into this now! It would be nice to catch two birds with one > stone. I'll also consider Russell's comments as well. I will admit I kept > the initial scope of this PR small, as I am still getting fully acquainted > with the details of Java functional programming (as I'm definitely more of > a Scala dev in my day job). But this is a great opportunity to learn and > that's definitely part of why I'm here. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/apache/iceberg/pull/1493#issuecomment-699570155>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADE2YKNBE7JOY74MXTVY63SH2IZZANCNFSM4RW4XABQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
