pvary commented on a change in pull request #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r494283939
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -139,6 +140,8 @@ protected void doRefresh() {
@Override
protected void doCommit(TableMetadata base, TableMetadata metadata) {
+ boolean updateTable = base != null ||
metadata.propertyAsBoolean(TABLE_FROM_HIVE, false);
Review comment:
If we do not want to use properties for signaling this behavior (looking
at it again with fresh eyes seems like a hack), then we have to modify:
- add method TableBuilder.updateExisting
- add method TableOperations.commit with new parameter signaling update
- add method HiveTableOperations/HadoopTableOperations to signal the update
Or we have to resort to parameters sending/hacking through some level and
removing the parameter from the lower levels.
I do not like any of these solutions, so happy to go with any other viable
solution...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
