pvary commented on a change in pull request #1495:
URL: https://github.com/apache/iceberg/pull/1495#discussion_r494586086
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -139,6 +140,8 @@ protected void doRefresh() {
@Override
protected void doCommit(TableMetadata base, TableMetadata metadata) {
+ boolean updateTable = base != null ||
metadata.propertyAsBoolean(TABLE_FROM_HIVE, false);
Review comment:
Yes, you are right.
With the HiveMetaHooks we have the possibility to do some `preCreate` and
`commitCreate` stuff, but the table should be created by the HMS between these
phases. I have even thought about dropping the HMS created table in the
`commitCreate` method but that seems like a serious waste of effort, and also I
do not have a HMS client at hand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
