xxubai commented on code in PR #13056:
URL: https://github.com/apache/iceberg/pull/13056#discussion_r2095807748
##########
data/src/main/java/org/apache/iceberg/data/GenericAppenderFactory.java:
##########
@@ -129,7 +129,7 @@ public FileAppender<Record> newAppender(OutputFile
outputFile, FileFormat fileFo
public FileAppender<Record> newAppender(
EncryptedOutputFile encryptedOutputFile, FileFormat fileFormat) {
MetricsConfig metricsConfig =
- table != null ? MetricsConfig.forTable(table) :
MetricsConfig.fromProperties(config);
+ table != null ? MetricsConfig.forTable(table) :
MetricsConfig.getDefault();
Review Comment:
I have the same concern — some external calls tend to configure metric
properties via `config`.
I agree with your suggestion to throw an argument exception first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
